fix dead lock in multi DB when using batchUpdate(#31038) #31118
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-Jason
force-pushed
the
master
branch
2 times, most recently
from
2b82310
to
7622e69
Compare
There was a problem hiding this comment.
- You can wait for Fixes nativeTest failure under GraalVM Native Image due to class information changes #31320 to be merged and then rebase to the master branch. Failure of nativeTest is expected and requires the fix of Fixes nativeTest failure under GraalVM Native Image due to class information changes #31320 .
|
I have rebased the master branch |
|
I am sorry,just misoperation |
linghengqian
reviewed
Jun 5, 2024
done |
linghengqian
reviewed
Jun 5, 2024
There was a problem hiding this comment.
- You need to change the
org.apache.shardingsphere.test.natived.jdbc.commons.TestShardingService#processSuccessInClickHouse(). Reference https://github.com/apache/shardingsphere/actions/runs/9387875307/job/25852084140?pr=31118#step:4:53356 .
Failures (1):
JUnit Jupiter:ClickHouseTest:assertShardingInLocalTransactions()
MethodSource [className = 'org.apache.shardingsphere.test.natived.jdbc.databases.ClickHouseTest', methodName = 'assertShardingInLocalTransactions', methodParameterTypes = '']
=> java.lang.AssertionError:
Expected: <[1, 1, 1, 1, 1, 0, 0, 0, 0, 0]>
but: was <[0, 0, 0, 0, 0, 1, 1, 1, 1, 1]>
org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
org.apache.shardingsphere.test.natived.jdbc.commons.TestShardingService.processSuccessInClickHouse(TestShardingService.java:100)
org.apache.shardingsphere.test.natived.jdbc.databases.ClickHouseTest.assertShardingInLocalTransactions(ClickHouseTest.java:47)
[email protected]/java.lang.reflect.Method.invoke(Method.java:580)
[email protected]/java.util.ArrayList.forEach(ArrayList.java:1596)
[email protected]/java.util.ArrayList.forEach(ArrayList.java:1596)
done |
linghengqian
approved these changes
Jun 5, 2024
Thank you for your recognition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31038.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.